Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix & update package #1

Merged
merged 3 commits into from
Sep 7, 2019
Merged

Fix & update package #1

merged 3 commits into from
Sep 7, 2019

Conversation

zoheirkhonyagar
Copy link
Contributor

@zoheirkhonyagar zoheirkhonyagar commented Sep 5, 2019

  • Fix batchClassification url
  • Replace callback with promise
  • Update README
  • Add examples

Copy link
Owner

@DrEhsan DrEhsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job bro 👍

To do:

it might be useful to have an api in server side for uploading our data sets using api
also making modules might be useful if we could create or edit using api
for next step i prefer make module chooser and initialize it inside vakavic constructor class

@DrEhsan DrEhsan merged commit a655e15 into DrEhsan:master Sep 7, 2019
@zoheirkhonyagar
Copy link
Contributor Author

Thank you bro this is a good suggestion,
I like that ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants