Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Austrian (+43) numbers #46

Merged
merged 1 commit into from
Oct 5, 2015
Merged

Add unit tests for Austrian (+43) numbers #46

merged 1 commit into from
Oct 5, 2015

Conversation

gpoul
Copy link
Contributor

@gpoul gpoul commented Oct 5, 2015

No description provided.

DrHyde added a commit that referenced this pull request Oct 5, 2015
Add unit tests for Austrian (+43) numbers
@DrHyde DrHyde merged commit 02ec123 into DrHyde:master Oct 5, 2015
@DrHyde
Copy link
Owner

DrHyde commented Oct 5, 2015

Is +43 828 20200 valid? According to libphonenumber it's one digit short - +43 828 followed by six digits, however, would be "shared cost", so "specialrate" in Number::Phone terms. See https://github.com/googlei18n/libphonenumber/blob/master/resources/PhoneNumberMetadata.xml#L1533

If libphonenumber is wrong then I can submit an update to them. In the mean time, however, I've commented out the tests for that number.

DrHyde added a commit that referenced this pull request Oct 5, 2015
@DrHyde
Copy link
Owner

DrHyde commented Oct 5, 2015

Hmm, OK, I found a reference on RTR's website that says it's valid. Bug report submitted upstream :-)

@gpoul
Copy link
Contributor Author

gpoul commented Oct 5, 2015

Yes, I just verified that +43 828 20200 is indeed a valid number. It was used for a text messaging fo a mobile parking service.

Thanks for fixing the special rates. I wasn't sure what the definition was for those. For +43 900 numbers it is pretty clear, but for +43 810 I wasn't sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants