forked from AdamMaras/vscode-overtype
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
George Melissourgos
committed
Feb 22, 2022
1 parent
a863c84
commit 2299568
Showing
2 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2299568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DrMerfy Why is that a fix? Version 0.4.5 worked totally fine with vscode 1.55, version 0.4.6 cannot be installed because of the engine update.
In case there are new APIs it is definitely necessary to upgrade the dependency, but I haven't seen a change making this necessary (#27 increased that to 1.34 so I guess that would be fine).
Can I request a version with an engine downgrade to 1.55?
BTW: switching from tslint to eslint and fixing the new warnings may be a reasonable thing, too; but that's independent.
2299568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitMensch Hey! Long time no see :) I remember there was something with the compilation not passing. I'll take a look and bump it down to 1.55 if it works.