Skip to content

Commit

Permalink
Fixed dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
George Melissourgos committed Feb 22, 2022
1 parent a863c84 commit 2299568
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
@@ -1,6 +1,6 @@
{
"name": "overtype",
"version": "0.4.5",
"version": "0.4.6",
"displayName": "Overtype",
"description": "Provides insert/overtype mode.",
"publisher": "DrMerfy",
Expand All @@ -26,7 +26,7 @@
},
"main": "./out/extension",
"engines": {
"vscode": "^1.34.0"
"vscode": "^1.63.1"
},
"activationEvents": [
"*"
Expand Down Expand Up @@ -88,8 +88,8 @@
"compile": "tsc -watch -p ./"
},
"devDependencies": {
"@types/vscode": "^1.63.1",
"tslint": "^6.1.3",
"typescript": "^4.5.4"
"@types/vscode": "1.63.1",
"tslint": "6.1.3",
"typescript": "4.5.4"
}
}

2 comments on commit 2299568

@GitMensch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrMerfy Why is that a fix? Version 0.4.5 worked totally fine with vscode 1.55, version 0.4.6 cannot be installed because of the engine update.
In case there are new APIs it is definitely necessary to upgrade the dependency, but I haven't seen a change making this necessary (#27 increased that to 1.34 so I guess that would be fine).

Can I request a version with an engine downgrade to 1.55?

BTW: switching from tslint to eslint and fixing the new warnings may be a reasonable thing, too; but that's independent.

@DrMerfy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitMensch Hey! Long time no see :) I remember there was something with the compilation not passing. I'll take a look and bump it down to 1.55 if it works.

Please sign in to comment.