Respect language-specific cursorStyle setting #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load configuration with language scope for the language
set in the active editor.
For example, if the following is in `.vscode/settings.json`
```json
"editor.cursorStyle": "line",
"[lua]": {
"editor.cursorStyle": "block",
}
```
then the cursor would be "line" instead of "block" in Lua files
when this extension enabled. After this commit, it has "block" style.
The language-specific scope API was added in some more recent
version of VS Code. Tried to bump up the `vscode` package version
but turns out it's deprecated so replace the package with
`@types/vscode`. Remove the no longer needed (and working)
`postinstall` script. Update lock files which changed after
`npm install`.
|
Hello, thanks for the request! This seems a cool feature, I'll test a bit locally and if everything seems good it will be passed into a release. |
|
@MrSimbax Sorry for the late reply, I have been real busy. I checked the commit and it works good. |
|
@all-contributors please add @MrSimbax for code |
|
I've put up a pull request to add @MrSimbax! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load configuration with language scope for the language
set in the active editor.
For example, if the following is in
.vscode/settings.jsonthen the cursor would be "line" instead of "block" in Lua files
when this extension is enabled. After this commit, it has "block" style.
The language-specific scope API was added in some more recent
version of VS Code. Tried to bump up the
vscodepackage versionbut turns out it's deprecated so replace the package with
@types/vscode. Remove the no longer needed (and working)postinstallscript. Update lock files which changed afternpm install.