call pendingDestroy when add image

[taoabc]

Call json.addToCache will call pendingDestroy internally, but add image to textureManager will not, so I call pendingDestroy manually.

[akdcl]

@jcyuan

[jcyuan]

👍 good catch, a potential bug of memory leak.
but we can just use image.addToCache(); instead.
the old code should be a legacy problem made when immigrating to the new db file plugin.

[jcyuan]

could please change to image.addToCache()

[taoabc]

I don't recommend add this image to cache because we already add image to textureManager, will become more heavier. What do you think? 😁

[jcyuan]

image.addToCache, this action actually does 2 things:
1, add the loaded image into the textureManager belongs to the loader. (global to scene)
2, call pendingDestroy to prepare to delete the stuffs created when loading the images

only a diffenent between them is, addToCache detects to see if the image to be loaded has a normal map or not, if it does, add to cache too.

so actually they are the same, but use Phaser's API is more sensible because you don't knwo whether they will be changed in the furture or not, right?

[taoabc]

You're right, I've changed to addToCache

[jcyuan]

you forgot to remove line this.loader.textureManager.addImage(image.key, image.data); , as it becomes useless now. 🍭

[taoabc]

Sorry for misunderstand your suggest, fixed and refresh output files at newest commit.

[jcyuan]

thanks for your effort @taoabc 👍