u3d/install: verify package names before we ensure setup coherence (fixes #385) (regression from 1.2.0) #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
force-pushed
the
fix/install_detect_invalid_package_name
branch
from
34bca38
to
4c2bb75
Compare
niezbop
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Fine for me. Maybe we could document that this is a regression introduced in #375 ?
https://github.com/DragonBox/u3d/pull/375/files#diff-15e7e91e585510202cfab8b3cc3e8d08R155-R161
The enforce setup coherence was moved before the validate package name...
lacostej
changed the title
lacostej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
Fixes #385