u3d/installer: Enable the download/installation of modules from Unity Hub #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still WIP, the specs are broken since the mocking is haywire. Plus some additional specs are needed |
lacostej
reviewed
Nov 9, 2019
| UI.verbose "Loading modules for several versions: #{version}" | ||
| load_versions_modules(version, cached_versions, os, offline) | ||
| else | ||
| UI.verbose "Loading modules for version #{version}" |
There was a problem hiding this comment.
Could we reuse the same load_versions_modules method and pass [version] to reduce code?
There was a problem hiding this comment.
It would change the interface though.
load_version_module returns an array of modules, while load_versions_module returns an hash of version, array of modules.
Maybe we want to clean that up though.
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
2 times, most recently
from
d774ba4
to
002e2a3
Compare
niezbop
changed the title
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
from
f3c197d
to
a20798e
Compare
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
from
aefbf9c
to
cb3eb3c
Compare
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
from
7869aa2
to
5bf184f
Compare
lacostej
reviewed
Nov 13, 2019
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
from
1edc419
to
abd3578
Compare
…handled by constructor
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
2 times, most recently
from
f3f8ab8
to
2b698d3
Compare
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
from
2b698d3
to
8d9ad6e
Compare
niezbop
force-pushed
the
feature/installer/sdk_ndk
branch
from
55e924c
to
a1be0f6
Compare
lacostej
reviewed
Nov 13, 2019
| end | ||
| end | ||
|
|
||
| def detect_installed_packages(packages, unity) |
There was a problem hiding this comment.
These methods could be moved inside the Unity Installation class
lacostej
reviewed
Nov 13, 2019
| def [](key) | ||
| return nil unless @ini | ||
| @ini[key] | ||
| def ini |
lacostej
approved these changes
Nov 13, 2019
|
Great that you kept the backward compatibility as much as possible. 💯 👍 |
lacostej
reviewed
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
Some new modules available through the Unity Hub are not accessible through the previous .ini standard.
This PR standardizes the concept of module by introducing the
UnityModuleclass, which can be generated fromINIModulesParser(previously INIparser) orHubModulesParser. This is a rather large PR since this concept was quite widely spread across the application.Fixes #359 by making the SKD/NDK packages accessible