gzip: Set file flags after setting file times #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also: freebsd/freebsd-src@c7b6525 |
dragonflybot
pushed a commit
that referenced
this pull request
Mar 6, 2024
Only set the source file flags on the target file after the timestamp has been set; otherwise setting the timestamp will fail if the flags don't permit it (i.e., uchg). To reproduce the issue: $ /usr/bin/touch /tmp/foo $ /bin/chflags uchg /tmp/foo $ /usr/bin/gzip -v /tmp/foo gzip: couldn't utimes: /tmp/foo.gz: Operation not permitted GitHub PR: #21 See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=120208
|
Committed. I'll also cherry-pick it to the 6.4 release. Thank you, @ricardobranco777. |
dragonflybot
pushed a commit
that referenced
this pull request
Mar 6, 2024
Only set the source file flags on the target file after the timestamp has been set; otherwise setting the timestamp will fail if the flags don't permit it (i.e., uchg). To reproduce the issue: $ /usr/bin/touch /tmp/foo $ /bin/chflags uchg /tmp/foo $ /usr/bin/gzip -v /tmp/foo gzip: couldn't utimes: /tmp/foo.gz: Operation not permitted GitHub PR: #21 See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=120208
iteratee
pushed a commit
to iteratee/DragonFlyBSD
that referenced
this pull request
Mar 13, 2024
…ime() Partially based on OpenBSD's wg code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gzip(1) cannot preserve utimes() because it first sets chflags()