Cleanup some nits (gcc -Wextra) #571
Conversation
| @@ -96,7 +96,6 @@ void display_init( resolution_t res, bitdepth_t bit, uint32_t num_buffers, gamma | |||
| /* Can't have the video interrupt happening here */ | |||
| disable_interrupts(); | |||
|
|
|||
| /* Minimum is two buffers. */ | |||
There was a problem hiding this comment.
I think updating the comment is preferable to removing it. While code obviously takes precedence over comments in terms of information value, a comment as a snapshot in time serves as a possible reminder of any assumptions, motivations, or limitations that were held at the time the comment was written. Someone looking at this code 5 years from now might struggle to imagine why the code is doing what it's doing if there is no comment attached.
| { | ||
| assert(idx >= 0 && idx < symt->addrtab_size); | ||
| assert(idx < symt->addrtab_size); |
There was a problem hiding this comment.
Is there a specific rationale for this int/unsigned changes? In general I prefer to use signed numbers because they have less suprising behaviors in case of bugs, I've had quite a few issues with unsigned having surprising behaviors.
| min -= 1; | ||
| entry = symt_addrtab_entry(symt, min); | ||
| } | ||
| if (idx != NULL) *idx = min; |
There was a problem hiding this comment.
Also what's the rationale of this? Is there some GCC -Wextra warning on this?
| @@ -509,7 +514,7 @@ static void backtrace_foreach(void (*cb)(void *arg, void *ptr), void *arg) | |||
| return; | |||
| } | |||
| } | |||
| // FALLTHROUGH! | |||
| __attribute__((fallthrough)); | |||
There was a problem hiding this comment.
I thought this was matched by GCC, but I guess if you changed it, it wasn't?
I think it should match this regex:
[ \t.!]*(ELSE,? |INTENTIONAL(LY)? )?
FALL(S | |-)?THR(OUGH|U)[ \t.!]*(-[^\n\r]*)?```
which is one of the various used by `-Wimplicit-fallthrough`
| @@ -470,7 +470,7 @@ void graphics_draw_character( surface_t* disp, int x, int y, char ch ) | |||
|
|
|||
| for( int yp = sy; yp < ey; yp++ ) | |||
| { | |||
| const register int run = yp * sprite_font.sprite->width; | |||
| register const int run = yp * sprite_font.sprite->width; | |||
There was a problem hiding this comment.
Since you're touching this, just drop register
No description provided.