[BinanceUsdM] add binance usd futures support #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techfreaque
force-pushed
the
add_binance_usd_m_support
branch
4 times, most recently
from
fd50461
to
993ea57
Compare
techfreaque
force-pushed
the
add_binance_usd_m_support
branch
from
9410c30
to
602b654
Compare
techfreaque
force-pushed
the
add_binance_usd_m_support
branch
3 times, most recently
from
ae89bd4
to
b14ed0b
Compare
techfreaque
force-pushed
the
add_binance_usd_m_support
branch
3 times, most recently
from
cd808de
to
e02d48a
Compare
Herklos
reviewed
Mar 19, 2023
| inverse: bool, | ||
| tp_sl_mode: trading_enums.TakeProfitStopLossMode, | ||
| ): | ||
| # no partial tp / sl - use limit and stop market instead |
There was a problem hiding this comment.
Should we raise here to avoid giving the impression that it worked?
There was a problem hiding this comment.
oh yeah now we raise NotImplementedError
Comment on lines
228
to
229
| # if size == constants.ZERO: | ||
| # return {} # Don't parse empty position |
There was a problem hiding this comment.
Should it be uncommented or removed?
techfreaque
force-pushed
the
add_binance_usd_m_support
branch
from
e02d48a
to
8a16b34
Compare
|
when we add suppor for exchanes, we are automating 2 test bundles:
Both have a future and spot trading version. If we want to officially support binanceusdm, we will need to have all those tests passing in their futures version. They are designed to make sure that everything octobot needs is working as expected in a particular exchange. It's also helping a lot when developing exchange connectors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far it seems to work very well
requires: Drakkar-Software/OctoBot-Trading#820
edit:
One thing to note is the get_price_ticker, its fetching funding rate as well, to get funding rate and mark_price.
Once there is way to set MARK_PRICE_IN_FUNDING_RATE and FUNDING_RATE_IN_FUNDING_RATE, the get_price_ticker method can be removed
Im not using the mark price in the position, as the mark price is only available once you have placed at least one (unfilled limit) order