-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BinanceUsdM] add binance usd futures support #794
base: dev
Are you sure you want to change the base?
[BinanceUsdM] add binance usd futures support #794
Conversation
fd50461
to
993ea57
Compare
9410c30
to
602b654
Compare
ae89bd4
to
b14ed0b
Compare
cd808de
to
e02d48a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @techfreaque! Thanks
inverse: bool, | ||
tp_sl_mode: trading_enums.TakeProfitStopLossMode, | ||
): | ||
# no partial tp / sl - use limit and stop market instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we raise here to avoid giving the impression that it worked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah now we raise NotImplementedError
# if size == constants.ZERO: | ||
# return {} # Don't parse empty position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be uncommented or removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it
e02d48a
to
8a16b34
Compare
so far it seems to work very well
requires: Drakkar-Software/OctoBot-Trading#820
edit:
One thing to note is the get_price_ticker, its fetching funding rate as well, to get funding rate and mark_price.
Once there is way to set MARK_PRICE_IN_FUNDING_RATE and FUNDING_RATE_IN_FUNDING_RATE, the get_price_ticker method can be removed
Im not using the mark price in the position, as the mark price is only available once you have placed at least one (unfilled limit) order