Skip to content

Commit

Permalink
cli/sql: increase maxHistEntries
Browse files Browse the repository at this point in the history
In light of PR cockroachdb#88272, we don't need the limit to be as low as 1000.
This commit increases it back to 10000, which is the common default in
unix shells and the screen/tmux utilities.

Release note: None
  • Loading branch information
knz committed Sep 22, 2022
1 parent f08a1b0 commit 88774f8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cli/clisqlshell/sql.go
Original file line number Diff line number Diff line change
Expand Up @@ -2164,7 +2164,7 @@ func (c *cliState) configurePreShellDefaults(
// anyone. We do prefer a limit however (as opposed to no limit at
// all), to prevent abnormal situation where a history runs into
// megabytes and starts slowing down the shell.
const maxHistEntries = 1000
const maxHistEntries = 10000

c.ins.SetCompleter(c)
if err := c.ins.UseHistory(maxHistEntries, true /*dedup*/); err != nil {
Expand Down

0 comments on commit 88774f8

Please sign in to comment.