Remove Faraday #39
Merged
Remove Faraday #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-in-wi
requested review from
timbreitkreutz,
tayjohno,
andrewstucki,
iantance and
eterry1388
iantance
approved these changes
May 23, 2018
eterry1388
approved these changes
May 24, 2018
| request['Accept'] = "*/*" | ||
|
|
||
| if access_token | ||
| request['Authorization'] = "Bearer #{access_token}" |
There was a problem hiding this comment.
Is there a standard for quotes vs double-quotes in this project?
There was a problem hiding this comment.
Not at this point, it looks like. It's probably worth doing rubocop cleanups.
This was referenced May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of using
Net::HTTPdirectly and skipping Faraday. Avoids version conflicts that we and our customers are seeing.