Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting to add support for drop downs with custom elements. #242

Merged
merged 55 commits into from
Sep 12, 2023
Merged

Starting to add support for drop downs with custom elements. #242

merged 55 commits into from
Sep 12, 2023

Conversation

jachin
Copy link

@jachin jachin commented Aug 22, 2023 •
edited
Loading

Bugs

  • Multi Select Toggle highlighted selected items
  • Multi Select - un-select highlighted selected items when hitting the delete key
  • Datalist multi select is not working
  • Custom options are including the extra label bit
  • Default Option Group Ordering is not working
  • Filtering with the web worker does not seem to be working
  • Validation (no white space)

@jachin jachin linked an issue Aug 22, 2023 that may be closed by this pull request
Allow arbitrary HTML for the options with custom elements #235
Open
Jachin Rupe added 28 commits August 22, 2023 16:43
Fix the tests.
4448b50
Fix the web tests.
5958f0f
Working on the rendering of the dropdown items.
b81d832
Starting to refactor the option types.
4b440d8
Progress... I got a FancyOption Module done plus some others.
fa4d14c
More progress. Lots of things still broken.
33e5e4c 
Going through and seeing what's salvageable with the Option type.

Maybe we keep the Option type, maybe we don't.
Things are still broken but we've gone through the Option module.
812a752
Things are still broken but I've moved a bunch of code from OptionsUn…
f84c752 
…ilities to Option List.
More progress.
e23f308
Things stll are not quite compiling but we're getting closer.
977f1c0
Whoah, it's compiling.
64a887e 
Not the tests of course... but progress.
Starting to fix up the tests.
9d5f30e
Fixing more tests.
6620f1b
Fixing more tests.
d49b1a5
Fixing more tests.
7fe3dca
Fixing more tests.
1aa7e82
Tests are now compiling, but not passing.
2b56e7c
Removing some things we do not need.
0579d4b
Some refactoring for the highlighting functions.
a0b39f0
Some refactoring adding some additional tests.
3d69bda
Fixing issues with option highlighting.
b01796e
Fixing more tests.
44468df
Removing tests for a function we don't use (outside of tests)
fa437b5
Fixing more tests.
467f17e
Fixing more tests.
01df238
Fixing a bug with deselecting an option.
ab7d7b7
Removing a debugger statement.
940740a
Oy, well this looks wrong.
224d043
Jachin Rupe and others added 24 commits September 5, 2023 17:06
Fixing sorting. Getting the last of the broken unit tests working.
97046fc
@jachin
Merge pull request #243 from DripEmail/big-option-refactor
e4702ca 
Big option refactor
Fixing some logic around un-highlighting options.
1d48577 
Adding some tests.
Fixing a couple of bugs with highlighted and selecting options.
e8d90ab
Fixing up how new options are added for datalist multi select.
b48032a 
Adding more test cases but things are still a mess in datalist multi select.
Handle empty options for the datalist mulit select better.
3c43b01
Removing some debugger statements and cleaning up some things I don't…
58265bc 
… need.
Setting things up to handle deselecting options for the datalist.
359f2c3
Cleaning up the function to deselecting options.
f18f33f
Fixing datalist multi select.
3a798bc 
But broke customhtml multi select.
Fixing up the deselectAllSelectedHighlightedOptions function.
c486f49
Fixing up an example=.
0402ab3
Finish fixing the example.
1b80eae
Adding some unit tests to help prevent future regressions around sele…
14e6d7d 
…cting options.
Fixing up custom options.
8928ade
Cleaning up a bunch of stuff.
1b5782e 
I'm doing this now so I can get more out of all the manual testing I will probably have to do.
Removing a debug log statement.
56489d7
Test clean up and failing tests.
4f63bef
Tests are still failing but we're cleaning up some more tests.
a298722
Cleaning up a bunch of tests.
05c4265
Fixing a web test.
d218cba
So many debuggers to remove.
941e233
Fixing an issue with the highlighting of filter terms.
d05e5cf 
I ended up fixing it by trimming the white space for the `cleanLabel`
in the Javascript where it's parsing the DOM. Hopefully this is OK to do.

I'm also adding a bunch of unit tests that I wrote while searching for this bug.

I'm also fixing some typos.
Finish fixing up a unit test.
af506d0
@jachin jachin marked this pull request as ready for review September 12, 2023 16:38
@jachin jachin merged commit 2d408eb into master Sep 12, 2023
1 check passed
@jachin jachin deleted the 235-allow-arbitrary-html-for-the-options-with-custom-elements branch September 12, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow arbitrary HTML for the options with custom elements
1 participant
@jachin