Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's no way to dismiss this alert forever (And it interferes with VimiumC) #655

Closed
Zeioth opened this issue Jul 18, 2020 · 3 comments
Closed

Comments

@Zeioth
Copy link

Zeioth commented Jul 18, 2020

Problem:
There's no way to dismiss the alert forever.

How to reproduce:

  • Install the plugins 'VimiumC' and 'Simple tab groups'.
  • Create a tab group and select it.
  • On any website, press the key 'B', write some text to search a marker, and press ctrl+shift+enter to open it in a new tab.

Everytime you do it, you'll see the next window.
Captura de pantalla_2020-07-18_17-01-50

What should happen: Give the user an option to remember the selection, and don't show the page again.

Related links:

@Zeioth Zeioth changed the title Can't open the URL into container (Interference with the plugin VimiumC) There's no way to dismiss this alert forever (And it interferes with VimiumC) Jul 18, 2020
@Zeioth
Copy link
Author

Zeioth commented Jul 30, 2020

Bug confirmed, this is an issue of simple tab groups:
gdh1995/vimium-c#198 (comment)

@Drive4ik
Copy link
Owner

Drive4ik commented Oct 8, 2020

I cannot change this behavior because it will break the logic for working with other addons, for example "Firefox Multi-Account Containers", "Facebook Container", "Google Container" etc.

The only solution I see is to open a new tab with the container from the current tab with the addon. This is how opening links works, for example. If you are in the "Personal" container and open the link with the middle mouse button (in a new window), then this new tab has a parent tab container.
This change needs to be done in the VimiumC addon

@Zeioth
Copy link
Author

Zeioth commented Oct 8, 2020

It's been fixed by vimium-c, the issue can be closed. Thank you!

@Zeioth Zeioth closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants