Simple Tab Groups refuses Vimium C to open tabs in "No container" #198

Zeioth · 2020-07-18T15:38:28Z

Problem:
There's no way to dismiss the alert forever.

How to reproduce:

Install the plugins 'VimiumC' and 'Simple tab groups'.
Create a tab group and select it.
On any website, press the key 'B', write some text to search a marker, and press ctrl+shift+enter to open it in a new tab.

Everytime you do it, you'll see the next window.

What should happen: Give the user an option to remember the selection, and don't show the page again.

Related links:

gdh1995 · 2020-07-27T15:43:33Z

I've reproduced this.

This is a logic conflict between common extensions who want to create tabs, like Vimium C, and the Simple Tab Groups.

According to code, Vimium C can not affect the SimpleTabGroups's process of forcing new tabs created in a special tab container. So you'll have to wait for the author to fix Drive4ik/simple-tab-groups#655.

gdh1995 · 2020-08-21T16:52:39Z

Hello, I got an idea to solve this conflict, and please try this version of Vimium C: vimium_c-1.84.3-firefox-a2a88e7.zip

Installation: see https://github.com/gdh1995/vimium-c/wiki/Test-a-zip-package .

With this version, you'll need to change mappings of createTab (add opener option to those mapping lines):

map *** createTab opener

This is to ensure the newly tab belongs to a same container of a current tab's.

Zeioth · 2020-08-21T18:53:29Z

Extension Last Updated
August 21, 2020

I clicked "save".
I opened a new page
I press B to load from bookmarks
I press ctrl+shift to load it in a new tab.

But I still get the message. Perhaps my mappings were not correct?

gdh1995 · 2020-08-22T01:42:25Z

um, oh I forgot this issue is about Vomnibar. I just fix broken createTab. BTW, you ned to replace *** with your wanted keys.

…

---Original--- From: "Zeioth"<notifications@github.com> Date: Sat, Aug 22, 2020 02:53 AM To: "gdh1995/vimium-c"<vimium-c@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Dahan Gong"<gdh1995@qq.com>; Subject: Re: [gdh1995/vimium-c] Simple Tab Groups refuses Vimium C to open tabs in "No container" (#198) Extension Last Updated August 21, 2020 I clicked "save". I opened a new page I press B to load from bookmarks I press ctrl+shift to load it in a new tab. But I still get the message. Perhaps my mappings were not correct? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

gdh1995 · 2020-08-22T04:30:34Z

Please try this: vimium_c-1.84.3-firefox-9555c57.zip

unzip and load it
open options page, go to "Vomnibar settings"
modify the "actions" field: add opener to it
- the result will be like "actions": "opener"
try Vomnibar again

The above only fixes URLs from Vomnibar would be blocked, and you'll need to re-map all commands which are related about "open a URL" and add a new option of opener to those mappings. It whould be like:

map t createTab opener
map P openCopiedUrlInNewTab opener
shortcut createTab opener
# some other mappings with "opener" option

Note: the code above is only an example, so you'll need to use your preferred keys to replace those t, P and so on.

Zeioth · 2020-08-22T13:42:14Z

I can confirm, that config fixes the issue! I've tried the next with the parameters of your last post and it works fine:

t
shift+p
b -> ctrl+shift+enter
o -> ctrl+shift+enter

Out of curiosity, I have a question:
There's some way to inmediately go to the tab you open with "b -> ctrl+shift+enter" and "o -> ctrl+shift+enter"?

gdh1995 · 2020-08-22T13:47:54Z

On Vomnibar, Ctrl+Enter opens a suggestion item in a new tab and focuses it, and Ctrl+Shift+Enter will only open but not focus.

Zeioth · 2020-08-22T15:46:38Z

Feel free to close the issue now, or when you push the code. Thank you so much!!

gdh1995 · 2020-08-23T10:43:44Z

Hello, the v1.85.0 has been released on Firefox Add-ons, and you may take a try.

Zeioth · 2020-08-23T12:14:35Z

Thank you for telling me! I've updated to the latest version, and tested i,t and it's working correctly as long as I write the settings you provided me. Maybe It would be a good idea to make them default? As long as there's no more issues involved.

gdh1995 · 2020-08-23T12:17:30Z

It will affect the relations among tabs. for example, if another builda a tab tree, then those tabs from vomnibar / createTab should be roots, but not children of a common web page.

…

---Original--- From: "Zeioth"<notifications@github.com> Date: Sun, Aug 23, 2020 20:14 PM To: "gdh1995/vimium-c"<vimium-c@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Dahan Gong"<gdh1995@qq.com>; Subject: Re: [gdh1995/vimium-c] Simple Tab Groups refuses Vimium C to open tabs in "No container" (#198) Thank you for telling me! I've updated to the latest version, and tested i,t and it's working correctly as long as I write the settings you provided me. Maybe It would be a good idea to make them default? As long as there's no more issues involved. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Zeioth · 2020-08-23T13:54:48Z

I just noticed, NewTabAdapter is also affected by this issue:

If I try to use any of the previously mentioned shortcuts from NewTabAdapter start page, I get the "Can't open url in the personal container" error. Also when I enter the starting page, if one is provided.

gdh1995 · 2020-08-23T13:56:56Z

sad. the extension is a bit annoying. then i'll add an option to let adapter do the same logic like vimium c.

…

---Original--- From: "Zeioth"<notifications@github.com> Date: Sun, Aug 23, 2020 21:54 PM To: "gdh1995/vimium-c"<vimium-c@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Dahan Gong"<gdh1995@qq.com>; Subject: Re: [gdh1995/vimium-c] Simple Tab Groups refuses Vimium C to open tabs in "No container" (#198) I just noticed, NewTabAdapter is also affected by this issue: If I try to use any of the previously mentioned shortcuts from NewTabAdapter start page, I get the "Can't open url in the personal container" error. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

for gdh1995/vimium-c#198 (comment)

gdh1995 · 2020-08-26T16:25:57Z

Please test this: ~~this zip has a bug. wait for a while~~.

Show advanced options, enable the "Open target URL in a same container (group)." and then test it with Simple Tab Groups enabled.

gdh1995 · 2020-08-26T16:46:45Z

Please try this: newtab-1.2.0.zip.

Currently there's a limit: if Open target URL in a same container (group) is enabled, then Focus web page when creating a new tab will be auto enabled. It's because (I found) my current trick can not work with Simple Tab Groups if not moving focus.

Zeioth · 2020-08-26T17:31:42Z

I just tested it, I can confirm it works. I can't tell you how happy I am to have that annoying message out of my life. Thank you!!! I'll close the issue as soon as the new version is live.

gdh1995 · 2020-08-26T17:57:50Z

NewTab Adapter v1.3.0 has been released.

waynehoover · 2023-06-21T08:31:42Z

For those coming here later, the solution to this is to add "actions": "opener" to your Vomnibar settings.

Zeioth mentioned this issue Jul 18, 2020

There's no way to dismiss this alert forever (And it interferes with VimiumC) Drive4ik/simple-tab-groups#655

Closed

gdh1995 added enhancement firefox-only help wanted labels Jul 18, 2020

gdh1995 added cantfix external and removed enhancement help wanted labels Jul 27, 2020

gdh1995 changed the title ~~This may or not be Vimium-C's fault~~ Simple Tab Groups refuses Vimium C to open tabs in "No container" Jul 28, 2020

gdh1995 added a commit that referenced this issue Aug 21, 2020

createTab: support .opener for #198

5f664e7

gdh1995 added enhancement and removed cantfix labels Aug 21, 2020

Zeioth mentioned this issue Aug 23, 2020

Simple Tab Groups refuses to open tabs in "Container" cadeyrn/newtaboverride#217

Open

gdh1995 added a commit to gdh1995/vimium-c-helpers that referenced this issue Aug 26, 2020

newtab: add an option setOpener

a58c0bd

for gdh1995/vimium-c#198 (comment)

Zeioth closed this as completed Aug 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simple Tab Groups refuses Vimium C to open tabs in "No container" #198

Simple Tab Groups refuses Vimium C to open tabs in "No container" #198

Zeioth commented Jul 18, 2020

gdh1995 commented Jul 27, 2020

gdh1995 commented Aug 21, 2020

Zeioth commented Aug 21, 2020

gdh1995 commented Aug 22, 2020 via email

gdh1995 commented Aug 22, 2020

Zeioth commented Aug 22, 2020 •

edited

Loading

gdh1995 commented Aug 22, 2020

Zeioth commented Aug 22, 2020

gdh1995 commented Aug 23, 2020

Zeioth commented Aug 23, 2020

gdh1995 commented Aug 23, 2020 via email

Zeioth commented Aug 23, 2020 •

edited

Loading

gdh1995 commented Aug 23, 2020 via email

gdh1995 commented Aug 26, 2020 •

edited

Loading

gdh1995 commented Aug 26, 2020 •

edited

Loading

Zeioth commented Aug 26, 2020

gdh1995 commented Aug 26, 2020

waynehoover commented Jun 21, 2023 •

edited

Loading

Simple Tab Groups refuses Vimium C to open tabs in "No container" #198

Simple Tab Groups refuses Vimium C to open tabs in "No container" #198

Comments

Zeioth commented Jul 18, 2020

gdh1995 commented Jul 27, 2020

gdh1995 commented Aug 21, 2020

Zeioth commented Aug 21, 2020

gdh1995 commented Aug 22, 2020 via email

gdh1995 commented Aug 22, 2020

Zeioth commented Aug 22, 2020 • edited Loading

gdh1995 commented Aug 22, 2020

Zeioth commented Aug 22, 2020

gdh1995 commented Aug 23, 2020

Zeioth commented Aug 23, 2020

gdh1995 commented Aug 23, 2020 via email

Zeioth commented Aug 23, 2020 • edited Loading

gdh1995 commented Aug 23, 2020 via email

gdh1995 commented Aug 26, 2020 • edited Loading

gdh1995 commented Aug 26, 2020 • edited Loading

Zeioth commented Aug 26, 2020

gdh1995 commented Aug 26, 2020

waynehoover commented Jun 21, 2023 • edited Loading

Zeioth commented Aug 22, 2020 •

edited

Loading

Zeioth commented Aug 23, 2020 •

edited

Loading

gdh1995 commented Aug 26, 2020 •

edited

Loading

gdh1995 commented Aug 26, 2020 •

edited

Loading

waynehoover commented Jun 21, 2023 •

edited

Loading