Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate sponsors.json into Japanese (Copied from Droidkaigi website). #288

Merged
merged 1 commit into from
Feb 11, 2017

Conversation

takuaraki
Copy link
Contributor

@takuaraki takuaraki commented Feb 11, 2017

Issue

Overview (Required)

I copied sponsors category name from Droidkaigi website and paste to assets/json/sponsors.json.

Links

Screenshot

🍣 is also shown with no problem. (But it seems egg and salmon though webpage shows two tuna.)
I confirmed 🍣 is shown on API25 and API16.

Before After

@konifar
Copy link
Contributor

konifar commented Feb 11, 2017

👀

@@ -115,7 +115,7 @@
},

{
"category": ":sushi: Sponsor",
"category": "🍣スポンサー",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement 🍣

@konifar
Copy link
Contributor

konifar commented Feb 11, 2017

LGTM! 🍣 Thank you for contribution!

@konifar konifar merged commit 68c60b4 into DroidKaigi:master Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants