fix SearchSessionFragment : remember query text

[nanoyatsu]

fix SearchSessionFragment : remember query text, when come back after query searching

Issue

• close When come back to search screen after query searching, editText become empty #348

Overview (Required)

• Set(≒initialize) query text in SearchSessionsFragment::onCreateOptionsMenu.
  (SearchSessionsFragment::onCreateOptionsMenuでクエリテキストの設定をしました。)
• Second arg of searchView.setQuery() is false. Because I think submit is unnecessary, In this case searchResult is remembered in SearchSessionsViewModel.
  (searchView.setQuery()の第２引数はfalseにしています。この時検索結果はViewModelに覚えられていて、submitが不要と考えているためです。)

Links

• none.

Screenshot

• none.

Please let me know if there are strange points in my code & PR.🙏🙏🙏
(変なところがあったら教えてください！🙏🙏🙏)

[takahirom]

Thanks!
You can use uiModel.requireValue() for it 🙏

[takahirom]

Let me think some minutes 🙇

[takahirom]

Thank you for your PR. I thought a little based on your plan.
We can setQuery when not empty

data class UiModel(val searchResult: SearchResult) {
        fun isEmpty() = this == EMPTY

        companion object {
            val EMPTY = UiModel(SearchResult.EMPTY)
        }
    }

val searchResult = searchSessionsViewModel.uiModel.requireValue().searchResult
if (!searchResult.isEmpty()) {
  searchView.setQuery(searchResult.query, false)
}

[nanoyatsu]

I checked about LiveData.requireValue(). I should have used that.
Thank you for teaching 🙏🙏

and...
thank you code sample😭 I'll repair PR now.

[nanoyatsu]

sorry! I missed the sample...🙇
Which is preferred? The latter is now committed.

data class UiModel(val searchResult: SearchResult) {
        fun isEmpty() = this == EMPTY

        companion object {
            val EMPTY = UiModel(SearchResult.EMPTY)
        }
    }

val uiModel = searchSessionsViewModel.uiModel.requireValue()
if (!uiModel.isEmpty()) {
  searchView.setQuery(uiModel.searchResult.query, false)
}

or

class SearchResult(
    val sessions: List<Session>,
    val speakers: List<Speaker>,
    val query: String?
) {
    fun isEmpty() = this == EMPTY

    companion object {
        val EMPTY = SearchResult(listOf(), listOf(), null)
    }
}

val searchResult = searchSessionsViewModel.uiModel.requireValue().searchResult
if (!searchResult.isEmpty()) {
    searchView.setQuery(searchResult.query, false)
}

[takahirom]

Thanks for suggestions! 🔍
Personally, there is a possibility that UiModel has something other than search results, so SearchResult.isEmpty() seems better.

[nanoyatsu]

thank you review.🙏
SearchResult.isEmpty() version is already committed. Because I noticed "missed the sample" after committed... 🙇
So, don't I need to commit anymore fix? (「なので、これ以降の修正は不要でしょうか？」的な意味のことを言いたいです...)

(「SearchResult.isEmpty のほうがベターだね」という読み取りをしています。そもそも間違っていたらすみません...)

[takahirom]

Sorry for my bad English 🙇
You are correct!

[takahirom]

LGTM! Thank you for fixing this issue!

[nanoyatsu]

thank you comment!
This PR was an irreplaceable experience for me.