Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] explicit running thread when collecting coroutine flow #367

Merged
merged 1 commit into from Sep 11, 2022
Merged

[iOS] explicit running thread when collecting coroutine flow #367

merged 1 commit into from Sep 11, 2022

Conversation

RyuNen344
Copy link
Contributor

@RyuNen344 RyuNen344 commented Sep 11, 2022 •
edited

Issue

  • close nothing

Overview (Required)

  • iOS app crash when launching
2022-09-11 15:28:47.204205+0900 DroidKaigi2022[17747:5918236] *** Terminating app due to uncaught exception 'NSGenericException', reason: 'Calling Kotlin suspend functions from Swift/Objective-C is currently supported only on main thread'
  • I put DispatcheQueue.main to explicit running thread
  • I don't know what is the best, so please tell me if more beautiful deal

Links

Screenshot

Before After

@RyuNen344 RyuNen344 marked this pull request as ready for review September 11, 2022 06:33
ry-itto
ry-itto approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I thought @MainActor would work, but after trying it, it doesn't seem to work. So, I hope to improve this at another time.

@ry-itto ry-itto merged commit b2e2639 into main Sep 11, 2022
@ry-itto ry-itto deleted the fix/ios-flow-collect-thread branch September 11, 2022 15:42
@ShotaKashihara ShotaKashihara mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RyuNen344 @ry-itto