Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Use @MainActor instead of DispatchQueue.main #390

Merged
merged 1 commit into from Sep 12, 2022
Merged

[iOS] Use @MainActor instead of DispatchQueue.main #390

merged 1 commit into from Sep 12, 2022

Conversation

ShotaKashihara
Copy link
Contributor

Issue

  • N/A

Overview (Required)

  • This PR is another idea to improve this patch
  • I suggest using @MainActor instead of DispatchQueue.main.
  • No crashes have occurred, but there may yet be a better way 馃槃

Links

Screenshot

Before After

@takahirom
Copy link
Member

Looks great! Let's wait for ry-itto

ry-itto
ry-itto approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving!
This is what I wanted to do 馃檱

@ry-itto ry-itto merged commit 6d30f9d into DroidKaigi:main Sep 12, 2022
@ShotaKashihara ShotaKashihara deleted the kashihara/use-main-actor branch September 13, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShotaKashihara @takahirom @ry-itto