Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent implementation of the DataManagementSetup #14

Open
mpostol opened this issue Dec 3, 2019 · 3 comments
Open

Inconsistent implementation of the DataManagementSetup #14

mpostol opened this issue Dec 3, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mpostol
Copy link
Collaborator

mpostol commented Dec 3, 2019

It contributes to #7

  1. The implementation of the DataManagementSetup is provided by the NetworkEventsManager class. According to the separation of concerns rules, it is a placeholder to gather all external injection points used to compose the application, initialize the communication and bind to local resources. Therefore it should be used to implement ViewModel for the View layer.
  2. The NetworkEventsManager has wrong namespace - not consistent with the location in the project hierarchy.
  3. NetworkEventsManager is a partial class - what is the reason. Ther is no autogenerated code.
@mpostol mpostol added the enhancement New feature or request label Dec 3, 2019
@Drutol
Copy link
Owner

Drutol commented Dec 9, 2019

Hmm, not sure if I want to chage NetworkEventsManager that much. I treat this class a a "gateway"/"entry point" to the library. It gathers all other application defined components and uses them as well as passes them to the library.

Not sure where it implements ViewModel, all it does really is creating instances of:
NetworkDeviceUpdateSource paired with INetworkDevice implementations.

Point 2&3 have been fixed.

@mpostol
Copy link
Collaborator Author

mpostol commented Dec 9, 2019

I will review p. 1.

@mpostol
Copy link
Collaborator Author

mpostol commented Sep 26, 2020

According to the OOI documentation:

  • NetworkEventsManager:DataManagementSetup

Now `NetworkEventsManager is the wrapper? What is the reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants