-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetworkEventsManager
is tightly coupled with ConfigurationData
#7
Comments
At the time of writing this code the assumption was that configuration is static and does not change, hence it's treated as a part of application domain. That being said it's only being used for accessing extra pieces of metadata about given instance(repository) so removing it won't have much of an impact given that in the end it should come separately after obtaining information about given repository from external sources. Now that I think of it there will be 3 kinds of data to discover:
While the first two should be contained in one configuration file the third one is separate piece of data.
Not quite sure what you mean, separately from what? Reply to the first point may be duplicate of this.
What I meant here is from pure library user standpoint, right now we have this "fountain" of data in form of [ProcessVariable] public double PipeX001_FTX001_Output { get; private set; } or build one in runtime: Properties = new Dictionary<string, BuiltInType>
{
{ "DrumX001_LIX001_Output", BuiltInType.Double},
{ "PipeX002_FTX002_Output", BuiltInType.Double}
} and be done with it. It's just a "quality of life" feature. |
Thanks for comments. Let me distinguish two independent topics related to this part of code:
I will add comments to these topics separately. |
|
I will review the modification and report any problems in separate issues if needed. |
This approach is not compliant with the architecture proposed in:
Reactive Networking Application Architecture
It has very serious consequences:
You said
Unfortunately the library does not provide any easy way to map data onto properties which will be later used for displaying the data to the user.
- my concern is if it is true. RferenceApplication contains an example of how to do it.You said:
For this reason I had to build some sort of proxy which will allow to manage the process much more easily.
- my concern is how to prove it, how to measure the effort required to (not sure) to implement or to understand or both.The text was updated successfully, but these errors were encountered: