Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for SW_Flow_lib.c #117

Closed
dschlaep opened this issue Dec 20, 2017 · 1 comment · Fixed by #218
Closed

Add unit tests for SW_Flow_lib.c #117

dschlaep opened this issue Dec 20, 2017 · 1 comment · Fixed by #218
Assignees
@CaitlinA @cjb643
Labels
enhancement in progress
Milestone
Code testing

Comments

@dschlaep
Copy link
Member

High priority functions for which to write unit tests:

  • grass_intercepted_water, shrub_intercepted_water, tree_intercepted_water, forb_intercepted_water
  • infiltrate_water_high, infiltrate_water_low
  • petfunc
  • svapor
  • transp_weighted_avg
  • grass_EsT_partitioning, shrub_EsT_partitioning, tree_EsT_partitioning, forb_EsT_partitioning
  • pot_soil_evap
  • pot_soil_evap_bs
  • pot_transp
  • watrate
  • evap_litter_veg_surfaceWater
  • evap_fromSurface
  • remove_from_soil
  • hydraulic_redistribution
  • soil_temperature, lyrTemp_to_lyrSoil_temperature, lyrSoil_to_lyrTemp_temperature, lyrSoil_to_lyrTemp, surface_temperature_under_snow, soil_temperature_init

Currently not operational functions, but for which we will also need unit tests: set_frozen_unfrozen, adjust_Tsoil_by_freezing_and_thawing
@dschlaep dschlaep added this to the Code testing milestone Dec 20, 2017
@CaitlinA CaitlinA self-assigned this Jan 10, 2018
CaitlinA added a commit that referenced this issue Jan 25, 2018
@CaitlinA
Update to unit_tests for Flow_lib functions to reflect veg arrays
5685688 
Unit tests for veg_intercepted_water and litter_intercepted_water

Issue #117
@cjb643 cjb643 self-assigned this Mar 9, 2018
CaitlinA added a commit that referenced this issue Mar 10, 2018
@CaitlinA
update to soil_temperature_init unit tests
345301f 
update to soil_temperature_init unit tests
Issue #117
CaitlinA added a commit that referenced this issue Mar 12, 2018
@CaitlinA
Small change to infiltrate_water_high unit test
2dbcedb 
Issue #117
@CaitlinA CaitlinA mentioned this issue Apr 26, 2018
Merged
@cjb643
Copy link
Contributor

cjb643 commented Jun 26, 2018

Unit tests have been added for the following functions:

  • veg_intercepted_water
  • infiltrate_water_high, infiltrate_water_low
  • petfunc
  • svapor
  • transp_weighted_avg
  • EsT_partitioning
  • pot_soil_evap
  • pot_soil_evap_bs
  • pot_transp
  • watrate
  • evap_fromSurface
  • remove_from_soil

Still need to add unit tests for functions:

  • evap_litter_veg_surfaceWater
  • hydraulic_redistribution

The unit tests for these functions have been added to the file test_SW_Flow_lib_temp.cc:

  • soil_temperature, lyrTemp_to_lyrSoil_temperature, lyrSoil_to_lyrTemp_temperature,
    lyrSoil_to_lyrTemp, surface_temperature_under_snow, soil_temperature_init
  • set_frozen_unfrozen

Currently not operational functions, but for which we will also need unit tests:

  • adjust_Tsoil_by_freezing_and_thawing

@cjb643 cjb643 mentioned this issue Jul 24, 2018
Merged
dschlaep added a commit that referenced this issue Oct 18, 2019
@dschlaep
Merge pull request #218 from DrylandEcology/Bugfix_117_Connor
acce170 
This version addressed documentation and unit testing:

User visible changes:
- Create and open documentation and user manual with `make doc doc_open`

Details:
- Documentation:
  - 'User manual' for SOILWAT2 provided as part of doxygen documentation (close #217, close #74)
  - Detailed installation instructions included in doxygen documentation (close #75)
  - Code contributor manual as part of doxygen documentation (close 86)
  - Doxygen warnings fixed (close #266)
  - Input units of biomass documented (close #265)

- Unit tests:
  - Contributed to the documentation and unit testing for all SOILWAT2 functions (see #216, see #219, see #76; close #73)
  - Unit tests for functions in `SW_Flow_lib.c` (close #117; contributed to #19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaitlinA CaitlinA

@cjb643 cjb643

Labels
enhancement in progress
Projects
None yet
Milestone
Code testing
Development

Successfully merging a pull request may close this issue.

Bugfix 117 connor DrylandEcology/SOILWAT2
3 participants
@dschlaep @CaitlinA @cjb643