setup of github actions for ci #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dschlaep
commented
Jan 23, 2022
•
dschlaep
commented
- the development of github actions should have been on a dedicated branch instead of on master since the start ...!
- move CI from travis and appveyor to github actions
- updated googletest requires newer gcc and clang versions than currently implemented for travis and appveyor scripts
- the development should have been on a dedicated branch instead of on master since the start ...! - add g++ for cygwin build
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=======================================
Coverage 53.98% 53.98%
=======================================
Files 20 20
Lines 3490 3490
=======================================
Hits 1884 1884
Misses 1606 1606
Continue to review full report at Codecov.
|
- warning was issued on github actions for a build on windows-release with cygwin and gcc v11.2.0 - the argument of `isalpha()` is "int ch" (https://en.cppreference.com/w/c/string/byte/isalpha) but we were passing in a "char" (which may be signed or unsigned depending on platform and compiler) - similarly to the use in the next line with `toupper()`, the fix is to convert to "int"
AddressSanitizer and LeakSanitizer are not available on cygwin (https://github.com/google/sanitizers, but see https://github.com/google/sanitizers/wiki/AddressSanitizerWindowsPort)
|
this PR will close issue #298 (Move CI to github actions) |
- new step "check_documentation" (only on linux): install doxygen, build SOILWAT2 documentation, and check that no unexpected warnings occurred - also: re-organized code coverage checks as separate job
- each job needs to check out the repository
- remove "main.yml" - move job "build_nix" into script "main_nix.yml" - move job "check_documentation" into script "check_doc.yml" - move job "build_Windows_Cygwin" into script "main_win.yml"
- update compiler version requirements for unit tests - update status badges (moving from travis and appveyor to github actions)
- move job "check_documentation" into script "check_doc.yml" (previously in "main.yml") - install also doxygen-latex and graphviz dependencies
- workflow names are used in badges on README -> long names display poorly
- workflow names are used in badges on README -> long names display poorly
- workflow names are used in badges on README -> long names display poorlygithub actions: use shorter name for doc workflow
…ogy/SOILWAT2 into feature_ghactions_v2
- fix doxygen "warning: documented empty return type ..." for functions that return "void": `lyrSoil_to_lyrTemp()`, `pot_soil_evap_bs()`, `write_headers_to_csv()`
- some doxygen hyperlinks no longer worked correctly -> use mostly markdown-style links (except for creating subpages) - however, html tags don't work for doxygen documentation (as of v1.9.3) (see issue #299)
- close issue #267 (Remove from doc/doxygen_exceptions.txt: "Unexpected html tag <img>...") - doxygen issue resolved with v1.8.16 (github actions installs v1.8.17 on ubuntu-release; and I get v1.9.3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.