Function _sxw_sw_setup unnecessarily calls SW_VPD_init
#335
Comments
dschlaep
added a commit
that referenced
this issue
Jul 8, 2019
…D_init` - close #335 The `SOILWAT2` function `SW_VPD_init` is called by `_begin_year` which in turn is called by `SW_CTL_run_current_year`. That the function `_begin_year` calls `SW_VPD_init` is "new" since `SOILWAT2` incorporated CO2-effects (commit DrylandEcology/SOILWAT2@1755c28 merged into [v3.5.0](https://github.com/DrylandEcology/SOILWAT2/releases/tag/v3.5.0)). Thus, the `STEPWAT2` function `_sxw_sw_setup` no longer needs to call `SW_VPD_init` because it will be called anyhow in due time by `SOILWAT2`. - this commit does not change testing output
|
closed by 35f66d1 |
|
@dschlaep thanks for catching this and documenting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
SOILWAT2functionSW_VPD_initis called by_begin_yearwhich in turn is called bySW_CTL_run_current_year. That the function_begin_yearcallsSW_VPD_initis "new" sinceSOILWAT2incorporated CO2-effects (commit DrylandEcology/SOILWAT2@1755c28 merged into v3.5.0).Thus, the
STEPWAT2function_sxw_sw_setupno longer needs to callSW_VPD_initbecause it will be called anyhow in due time bySOILWAT2.--> suggested fix: remove the call to
SW_VPD_initfrom function_sxw_sw_setupThis should make a run ever so slightly faster as we remove one of two yearly calls to
SW_VPD_initwhich loops seven times through each day of the year for each of the fourSOILWAT2vegetation types...The text was updated successfully, but these errors were encountered: