Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Group notifications #1163

Merged
merged 13 commits into from
Sep 5, 2023
Merged

✨ Group notifications #1163

merged 13 commits into from
Sep 5, 2023

Conversation

Macludde
Copy link
Collaborator

@Macludde Macludde commented Jul 5, 2023

No description provided.

@Macludde Macludde changed the title Group notifications ✨ Group notifications Jul 5, 2023
@Macludde Macludde marked this pull request as draft July 5, 2023 19:47
danieladugyan
danieladugyan requested changes Aug 3, 2023
View reviewed changes
backend/services/core/src/datasources/Events.ts Show resolved Hide resolved
frontend/pages/members/[id]/index.tsx Show resolved Hide resolved
backend/services/core/src/shared/database.ts Outdated Show resolved Hide resolved
backend/services/core/src/shared/database.ts Outdated Show resolved Hide resolved
@danieladugyan danieladugyan self-requested a review August 3, 2023 21:37
danieladugyan
danieladugyan previously approved these changes Aug 3, 2023
View reviewed changes
@danieladugyan
Copy link
Contributor

LGTM if everything works, I haven't tested it

@Macludde
Copy link
Collaborator Author

So I started working on this long ago (about 74 commits on the main branch, ago). But now I've finally had time to sit down and complete it and I THINK it's done. Feel free to look through it.

It will still need to be reworked a bit when the authors branch #1248 is merged as there is a specific case where a CustomAuthor published a news article, then I don't want the authors real first name/last name and profile picture to be shown, but the custom author's instead.

@Macludde Macludde marked this pull request as ready for review September 3, 2023 12:33
@Macludde
Copy link
Collaborator Author

Macludde commented Sep 5, 2023

@danieladugyan @oliverlevay Do you want to check this out or can I just merge?

danieladugyan
danieladugyan approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@danieladugyan danieladugyan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC everything looked fine code-wise when I last reviewed this MR, so merging is fine with me.

@Macludde Macludde merged commit 9de4a76 into main Sep 5, 2023
7 checks passed
@Macludde Macludde deleted the group-notifications branch September 5, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieladugyan danieladugyan danieladugyan approved these changes

@oliverlevay oliverlevay Awaiting requested review from oliverlevay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Macludde @danieladugyan