Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete package (w/o tests) #1

Merged
merged 16 commits into from
Aug 5, 2015
Merged

Complete package (w/o tests) #1

merged 16 commits into from
Aug 5, 2015

Conversation

bnhwa
Copy link
Collaborator

@bnhwa bnhwa commented Aug 4, 2015

Completed:

  • install
  • help without sudo
  • running with appropriate buffer size(given that the user waits for 30 seconds before running)
    • did this through adding splitter ports
  • enabled proper setup
  • includes README.md
  • includes hyperlinks to necessary
  • includes required versions of picamera

Incomplete:

  • Testing
  • Documentation of testing

@jakirkham
Copy link
Member

Thanks @bnhwa. I will review this and give you some feedback.

`python setup.py install`
Additionally, the program requires installation of `setuptools`; the link to the installation instructions is as follows: <https://pypi.python.org/pypi/setuptools>


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep one newline between sections for this file.

@jakirkham jakirkham changed the title Mouse_Record complete package(minus tests) Complete package (w/o tests) Aug 4, 2015
Additionally, the program requires installation of `setuptools`; the link to the installation instructions is as follows: <https://pypi.python.org/pypi/setuptools>


# Development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide some text here so we understand what we are doing with these commands. If you have questions, please ask.

os.makedirs(folder)
stream = picamera.PiCameraCircularIO(camera, seconds=z)
while True:
# Up until now, the program defines the arguments and settings for the Raspberry Pi camera and trigger event(GPIO 27)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably is too long and needs to be wrapped.

Defines arguments:

Args:
args = parser.parse_args(argv[1:]): All arguments stored as list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop = parser.parse_args(argv[1:])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add (strs)

Defines arguments:

Args:
argv(str): Arguments are stored as a list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align spacing.

@jakirkham
Copy link
Member

Thanks again for your hard work on the @bnhwa. Merging...

@jakirkham jakirkham merged commit 3496cc1 into DudLab:master Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants