Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable 401 on ~/bff/user endpoint when user is not logged in #108

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Add option to disable 401 on ~/bff/user endpoint when user is not logged in #108

merged 3 commits into from
Jun 27, 2022

Conversation

brockallen
Copy link
Member

Fixes: #104

@brockallen brockallen added this to the 2.0.0 milestone Jun 23, 2022
@brockallen
Copy link
Member Author

@leastprivilege any suggestions for better name for the UserEndpointReturnNullForAnonymousUser option?

UserEndpointAlwaysReturns200?
Disable401OnUserEndpoint?
Enable401OnUserEndpoint?
Allow401OnUserEndpoint?

@ryad -- any suggestions for a name for the option to toggle this behavior?

@brockallen brockallen added the enhancement New feature or request label Jun 24, 2022
@leastprivilege
Copy link
Member

Why not make it an enum

AnonymousSessionResponse.401
AnonymousSessionResponse.200

@brockallen
Copy link
Member Author

Done -- enum added for AnonymousSessionResponse.

@brockallen brockallen marked this pull request as ready for review June 27, 2022 13:19
@leastprivilege leastprivilege merged commit 666ea05 into main Jun 27, 2022
@leastprivilege leastprivilege deleted the brock/user_endpoint_401 branch June 27, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leastprivilege leastprivilege leastprivilege approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Allow ~/bff/user to not return 401
2 participants
@brockallen @leastprivilege