UnhandledExceptionEvent.ToString() Throws NotSupportedException

[JustusGreiberORGADATA]

Which version of Duende IdentityServer are you using?
6.3.2
Which version of .NET are you using?
NET 6
Describe the bug

1. System.Text.Json can't serialize exceptions. System.Text.Json - can't serialize exception dotnet/runtime#43026. It will refuse to serialize the contained IntPtr
2. UnhandledExceptionEvent contains an exception https://github.com/DuendeSoftware/IdentityServer/blob/main/src/IdentityServer/Events/UnhandledExceptionEvent.cs#L44
3. Event.ToString() calls LogSerializer.Serialize(this) which internally uses System.Text.Json https://github.com/DuendeSoftware/IdentityServer/blob/main/src/IdentityServer/Events/Infrastructure/Event.cs#L145

A clear and concise description of what the bug is.

To Reproduce

new UnhandledExceptionEvent(new Exception()).ToString();

should do it, although I haven't exactly tried, because in my case it happens during the OIDC flow (likely because I haven't migrated the database yet).

[josephdecock]

Hi, thanks for this bug report. So far I've been unable to reproduce the problem. I would expect this unit test to show the error, but it passes:

    [Fact]
    public void UnhandledExceptionEventCanCallToString()
    {
        var e = new UnhandledExceptionEvent(new Exception("Boom?"));

        var s = e.ToString();

        s.Should().NotBeNullOrEmpty();
    }

Does that test pass for you?

[JustusGreiberORGADATA]

Hi,

my bad, the non serializable data is only added to the exception, if it is thrown. Try this:

 [TestMethod]
 public void Test2()
 {
     try
     {
         throw new Exception();
     }
     catch (Exception ex)
     {
         var exception = new Duende.IdentityServer.Events.UnhandledExceptionEvent(ex);

         var myString = exception.ToString();
     }
 }

It should throw the exception

Test method Ofcas.Odid.IdentityProvider.UITests.ErrorPageTest.Test2 threw exception: 
    System.NotSupportedException: Serialization and deserialization of 'System.Reflection.MethodBase' instances are not supported. Path: $.Exception.TargetSite. ---> System.NotSupportedException: Serialization and deserialization of 'System.Reflection.MethodBase' instances are not supported.

[josephdecock]

Thanks @JustusGreiberORGADATA, I'm reproducing the error now.

[josephdecock]

@JustusGreiberORGADATA are you requesting that a fix for this issue be patched into the 6.3.x branch, or can you wait for v7?

[JustusGreiberORGADATA]

@josephdecock I know this is an issue now, so I don't care if it's only in v7. But just FYI: For other people upgrading to 6.3 it might be confusing, because the exception triggers if you are forgot to create the migrations.

[josephdecock]

@JustusGreiberORGADATA , a fix for this is now merged and will be part of the next major release.