Remove raw exception from unhandled exception event #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdecock
force-pushed
the
joe/unhandled-exception-event
branch
from
df621d8
to
9299ea7
Compare
josephdecock
force-pushed
the
joe/unhandled-exception-event
branch
from
9299ea7
to
df67a5e
Compare
brockallen
approved these changes
Jul 17, 2023
|
Given that we already capture the exception in the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #1362. Seems a bit heavy-handed to just completely remove the exception, but it can't be serialized anyway so I don't think we're losing much.