Brock/merge 6.3.7 #1490
Merged
Brock/merge 6.3.7 #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect LogWarning call
Demonstrates that the back channel logout service will create tokens with a bad issuer if it is missing from the logout request
Moved the fix from IdentityServerTools into the back channel logout service to avoid breaking changes in IdentityServerTools. While technically this is a breaking change in the back channel service too, this makes the impact much smaller, and more likely to be caught by the compiler. The previous implementation changed the semantics of a string parameter in a way that could have been surprising, vs this way adds a new constructor parameter in a way that will be totally obvious and caught by the compiler.
…ssuer Fix logout token iss when issuer is missing
# Conflicts: # src/IdentityServer/IdentityServerTools.cs # src/IdentityServer/Validation/Default/JwtBearerClientAssertionSecretParser.cs
|
@josephdecock Here's the PR to merge the patch back into main. Can you have a review and also do any cleanup that's needed (like the open TODO). Thx |
josephdecock
approved these changes
Dec 15, 2023
josephdecock
requested changes
Dec 15, 2023
On second thought, the service provider should be done on its own. This is good merge. |
josephdecock
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.