-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brock/merge 6.3.7 #1490
Brock/merge 6.3.7 #1490
Conversation
Fix incorrect LogWarning call
Demonstrates that the back channel logout service will create tokens with a bad issuer if it is missing from the logout request
Moved the fix from IdentityServerTools into the back channel logout service to avoid breaking changes in IdentityServerTools. While technically this is a breaking change in the back channel service too, this makes the impact much smaller, and more likely to be caught by the compiler. The previous implementation changed the semantics of a string parameter in a way that could have been surprising, vs this way adds a new constructor parameter in a way that will be totally obvious and caught by the compiler.
…ssuer Fix logout token iss when issuer is missing
# Conflicts: # src/IdentityServer/IdentityServerTools.cs # src/IdentityServer/Validation/Default/JwtBearerClientAssertionSecretParser.cs
@josephdecock Here's the PR to merge the patch back into main. Can you have a review and also do any cleanup that's needed (like the open TODO). Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I want to revisit the use of the service provider...
On second thought, the service provider should be done on its own. This is good merge. |
No description provided.