-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: RepRapFirmware 3.5.0-rc.1 and Screens 12864 #909
Comments
can you try using: button R0 C0 W63 F0 H1 T"Auto Level" A""M98 P0:/menu/scripts/autoLevel.g"" |
Does not work ((( |
|
Should be this I think:
|
Does not work ((( |
that's missing a third " between P and 0 ...
Gesendet von ProtonMail mobile
…-------- Original-Nachricht --------
Am 13. Sept. 2023, 16:29, schrieb X-Dron :
> Should be this I think:
>
> button R0 C0 W63 F0 H1 T"Auto Level" A"M98 P""0:/menu/scripts/autoLevel.g"""
Does not work (((
There is an empty command button and the command is not executed.
—
Reply to this email directly, [view it on GitHub](#909 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAJMOI37SWFSLPFA6OQXX2DX2G7OFANCNFSM6AAAAAA4WGQR6A).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Does not work ((( Error loading menu See src/Display/Menu.cpp
|
I think the best way is to change
|
I will look at this in more detail next week, but my current plan is to change ParseMenuLine to recognise a pair of adjacent double quote characters within a string literal as representing and embedded double quote character. |
I think it's better to leave the menu file syntax as is. So there is no need to update the parser. It parses the command and file path correctly. The G-code command generation syntax needs to be updated (ButtonMenuItem::Select). |
The problem lies in the parser. Given the argument A"M98 P""test.g""" it sets the string argument to"M98 P", then it parses "test.g" and treats that as an implicit T parameter (changing the button text), then it parses the final "" and treats that as an implicit T parameter (changing the button text to an empty string). So the parser needs to be fixed. RRF in standalone mode used to allow the P argument of M98 not to be quoted e.g. A"M98 Ptest.g" but that causes problems if you want to pass parameters to the macro. I have fixed the parser so that a line such as |
@dc42 This is a bad solution IMO as it introduces inconsistency into the menus language, e.g. for the In 3.5rc1, |
#0 expands to a quoted string, therefore it does not need to be quoted. |
It ( |
Duet Forum Discussion Thread
https://forum.duet3d.com/categories
Which Duet products are you using?
Firmware Version
RepRapFirmware 3.5.0-rc.1
Duet Web Control Version
DWC 3.5.0-rc.1
Are you using a Single Board Computer (RaspberryPi) with your Duet?
Please upload the results of sending M122 in the gcode console.
Please upload the content of your config.g file.
Please upload the content of any other releveant macro files.
No response
Details specific to your printer.
No response
Links to additional info.
No response
What happened?
Hi, after these changes:
M98 now requires the P parameter to be a quoted string. Previously, in standalone mode an unquoted string was permitted.
M98 now always requires the P parameter to be a quoted string.
starting macros from screens 12864 does not work
Does not work:
button R0 C0 W63 F0 H1 T"Auto Level" A"M98 P0:/menu/scripts/autoLevel.g"
Does not work too:
button R0 C0 W63 F0 H1 T"Auto Level" A"M98 P#0" L"/menu/scripts/autoLevel.g"
In RRF 3.5.0-beta.4 everything works correctly
The text was updated successfully, but these errors were encountered: