Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undead get the loyal icon but not the trait #424

Closed
Discontinuum opened this issue Sep 19, 2022 · 1 comment
Closed

Undead get the loyal icon but not the trait #424

Discontinuum opened this issue Sep 19, 2022 · 1 comment

Comments

@Discontinuum
Copy link
Contributor

Tarquin from the forum reports https://forums.wesnoth.org/viewtopic.php?p=676368#p676368

I'd like to file a bug report.
Recruiting undead has a chance to give them the loyalty icon, but the loyal trait is blocked from spawning on undead.
in global_events.cfg

https://github.com/Dugy/Legend_of_the_Invincibles/blob/master/utils/global_events.cfg#L1031

if an undead rolls loyality, this is set to 1; then a check is made if the unit is undead (it checks for a must have trait), if they have this trait, dont give them loyal. A bit further

https://github.com/Dugy/Legend_of_the_Invincibles/blob/master/utils/global_events.cfg#L1146

They are given the loyalty icon overlay, even if they don't have loyal

@Dugy Dugy closed this as completed in e0b0f3f Nov 16, 2022
Dugy added a commit that referenced this issue Nov 16, 2022
@Dugy
Copy link
Owner

Dugy commented Nov 16, 2022

I made the extra traits add as extra traits rather than replace existing ones. I used the replacement approach because I didn't know to append it at the end back at the time I was writing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants