Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necromancy always takes precedence over infected #474

Merged
merged 3 commits into from May 9, 2023

Conversation

Toranks
Copy link
Collaborator

@Toranks Toranks commented May 9, 2023

In the case that an Arch Necromancer infects another Arch Necromancer, and the Arch Necromancer dies from the poison on turn_refresh, it becomes walking corpse instead of a lich. This does not happen if he dies from other causes while infected, so it should be considered a bug. I assume necromancy should take precedence.
I also delete two unnecessary fire_event when unit becomes walking corpse. These events are executed as if the killed unit was the walking corpse, when it should be the necromancer. However, these events are not needed in this situation.

@Dugy
Copy link
Owner

Dugy commented May 9, 2023

Is the last event necessary? If the infected status does not trigger, the necromancy ability will, and to its job, no?

@Toranks
Copy link
Collaborator Author

Toranks commented May 9, 2023

Is the last event necessary? If the infected status does not trigger, the necromancy ability will, and to its job, no?

If I don't activate it, the unit won't die, since poison doesn't kill. But it is supposed that infection CAN kill. If it has 1 HP after being poisoned, it dies according to the code of this turn_refresh event.

@Dugy
Copy link
Owner

Dugy commented May 9, 2023

Aha, I see now.

@Dugy Dugy merged commit f0abbc4 into Dugy:master May 9, 2023
1 check passed
@Toranks Toranks deleted the fixed-necromancy-+-infected branch May 9, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants