Implement unit tests and configure for CircleCI #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test works but imports are not working
- Updates add_volume_binding in job to leave off unused params
- Previously maintained a list of job uids, but the client is only designed to observe one job right now
- Had factored this out to a function but was still attempting to call the instance method
johnbradley
approved these changes
Jan 11, 2019
There was a problem hiding this comment.
LGTM
It looks like the TODO added here already has an issue: #5
If you're referring to this one: https://github.com/Duke-GCB/calrissian/pull/13/files#diff-956797522b8eb18a8f5f03fda0de27edR31 I didn't really add it in this PR, just moved it around. But now that the TODOs are all converted to issues I'll take them out of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-mFixes #3