Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade predictors to python3 #19

Merged
merged 3 commits into from
Aug 23, 2019
Merged

Upgrade predictors to python3 #19

merged 3 commits into from
Aug 23, 2019

Conversation

dleehr
Copy link
Member

@dleehr dleehr commented Aug 23, 2019

Updates Dockerfile to install/run predict-tf-binding and predict-tf-preference using python 3 (See Duke-GCB/Predict-TF-Binding#46 and Duke-GCB/Predict-TF-Preference#5)

  • Switches base image to python 3.7, since installing python 3 on top of ubuntu could not install predict-tf-binding dependencies correctly.
  • Removes unnecessary LIBSVM installation (see Upgrade to Python 3 Predict-TF-Binding#46)

Tested on imads-dev

- Removing separate LIBSVM installation (it is now available via pip)
- Removes python-pip (Python 2) installer, since we're entirely python 3
- libsvm was failing to install due to an ascii codec error in python 3.5, so I switched from ubuntu base image to python 3.7
@dleehr dleehr changed the title Upgrade predictors python3 Upgrade predictors to python3 Aug 23, 2019
Copy link
Contributor

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dleehr dleehr merged commit a5586cb into master Aug 23, 2019
@dleehr dleehr deleted the upgrade-predictors-python3 branch August 23, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants