remove TODO comments related to issue #141

Duke-GCB · Jan 29, 2019 · f10defd · f10defd
1 parent f8b661f
commit f10defd
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lando/k8s/jobmanager.py b/lando/k8s/jobmanager.py
@@ -4,6 +4,7 @@
 import os
 
 DDSCLIENT_CONFIG_MOUNT_PATH = "/etc/ddsclient"
+TMP_VOLUME_SIZE_IN_G = 1
 
 
 class JobLabels(object):
@@ -37,28 +38,28 @@ def make_job_labels(self, job_step_type):
     def create_job_data_persistent_volume(self):
         self.cluster_api.create_persistent_volume_claim(
             self.names.job_data,
-            storage_size_in_g=self.job.volume_size,  # TODO better calculate this
+            storage_size_in_g=self.job.volume_size,
             storage_class_name=self.storage_class_name
         )
 
     def create_output_data_persistent_volume(self):
         self.cluster_api.create_persistent_volume_claim(
             self.names.output_data,
-            storage_size_in_g=self.job.volume_size,  # TODO better calculate this
+            storage_size_in_g=self.job.volume_size,
             storage_class_name=self.storage_class_name
         )
 
     def create_tmpout_persistent_volume(self):
         self.cluster_api.create_persistent_volume_claim(
             self.names.tmpout,
-            storage_size_in_g=self.job.volume_size,  # TODO better calculate this
+            storage_size_in_g=self.job.volume_size,
             storage_class_name=self.storage_class_name
         )
 
     def create_tmp_persistent_volume(self):
         self.cluster_api.create_persistent_volume_claim(
             self.names.tmp,
-            storage_size_in_g=1,  # TODO better calculate this
+            storage_size_in_g=TMP_VOLUME_SIZE_IN_G,
             storage_class_name=self.storage_class_name
         )