-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s job manager changes #140
Conversation
This class handles all the k8s interactions for running a workflow. It creates pvc, config maps, jobs, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I looked over everything, but as this is mostly underlying infrastructure did not attempt to run it myself.
|
||
class SecretVolume(VolumeBase): | ||
def __init__(self, name, mount_path, secret_name): | ||
super(SecretVolume, self).__init__(name, mount_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A super secret volume? 🔐
self.system_data = 'system-data-{}'.format(suffix) | ||
|
||
|
||
class Paths(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes removed from #139 to simplify the review process.
Adds a
k8s
module underlando
consisting of:ServerConfig
config file for k8s version of landoClusterApi
class for simplifying interacting with k8sJobManager
class that usesClusterApi
to create volumes and run jobs for various steps of running the job.JobManager
The
JobManager
has methods for creating jobs for the following job steps:lando/lando/k8s/jobmanager.py
Lines 15 to 19 in f8b661f
For each job step handled by
JobManager
there are at most 3 methods:In PR #139 the k8s lando server will use
JobManager
to run k8s jobs for various steps.Created #141 to improve the volume sizes for the persistent volume claims used in running a job.
ClusterApi
This class performs two main simplifications instead of using the python kubernetes module directly.