Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: degree not showing up in gradient background generator #310

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

HridoyHazard
Copy link
Contributor

@HridoyHazard HridoyHazard commented Oct 22, 2022

Fixes Issue #303

HridoyHazard PR closes #303

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

fixed the issue of empty deg indicator in gradient-background

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

image

@vercel
Copy link

vercel bot commented Oct 22, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
code-magic βœ… Ready (Inspect) Visit Preview Oct 22, 2022 at 8:23AM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2022

Please fix the compliance PR error above, if you don't know how, try this:

  • Read the error carefully or read the contributing file
  • Checkout past merged Pull requests to see how they were done for it to be merged

Note: you can edit your PR message, this PR won't be merged if the error isn't gone and may be closed if it isn't fixed soon

@HridoyHazard
Copy link
Contributor Author

didn't understand why it giving error ?? code is clean

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2022

Has nothing to do with your code and everything to do with thisπŸ‘‡πŸ½
Screenshot_2022-10-22-09-29-50-807_com.github.android.jpg

@HridoyHazard HridoyHazard changed the title fixed degree in gradient background fix: degree not showing up in gradient background generator Oct 22, 2022
@HridoyHazard
Copy link
Contributor Author

@Dun-sin fixed now

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2022

@Dun-sin fixed now

It's not, the message will change if it has

@HridoyHazard
Copy link
Contributor Author

@Dun-sin fixed now

It's not, the message will change if it has

bro check now it's showing green means no error

@HridoyHazard
Copy link
Contributor Author

@Dun-sin bro I'm new. can you plz explain what's wrong ? and what should i do to make this pr get merged ? i'm very confuse...

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2022

@Dun-sin bro I'm new. can you plz explain what's wrong ? and what should i do to make this pr get merged ? i'm very confuse...

My PR closes #issue_number_here

What does this meanπŸ‘†πŸ½

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2022

It's like my name is your_name_here in a form.

When filling it you do it like this: my name is Dunsin

If you actually bother to read it, you won't be confused, but you didn't.

@HridoyHazard
Copy link
Contributor Author

actually bro i did read it but couldn't understand. and also i checked other pr those doesn't have this option :/
is it ok now?

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good πŸ‘ŒπŸΎ Thank you for contributing your PR is accepted, I hope you continue to contribute to this project

Check out the community discord server πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 9886f96 into Dun-sin:main Oct 22, 2022
@HridoyHazard
Copy link
Contributor Author

thank you man

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2022

πŸŽ‰ This PR is included in version 2.21.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] degree not showing up in gradient background generator
2 participants