Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add NEXT_PUBLIC_ to env #602

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix: add NEXT_PUBLIC_ to env #602

merged 1 commit into from
Jan 26, 2024

Conversation

Dun-sin
Copy link
Owner

@Dun-sin Dun-sin commented Jan 26, 2024

Fixes Issue

**My PR closes #601 **

👨‍💻 Changes proposed (What did you do ?)

  • add the NEXT_PUBLIC_ for Next.js
  • changes Next.js dev command to turn on debugging by default
  • installed cross-env for debugging

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
whisper ✅ Ready (Inspect) Visit Preview Jan 26, 2024 6:51pm

@Dun-sin
Copy link
Owner Author

Dun-sin commented Jan 26, 2024

@mathiasayivor pls review asap

mathiasayivor
mathiasayivor approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@mathiasayivor mathiasayivor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dun-sin Dun-sin merged commit c5b6c1a into main Jan 26, 2024
4 checks passed
@Dun-sin Dun-sin deleted the fix/issue-env branch January 26, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasayivor mathiasayivor mathiasayivor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] env isn't set up properly for next.js
2 participants
@Dun-sin @mathiasayivor