Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout from 3 to 4 #237

Merged
merged 13 commits into from
Nov 13, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2023

Bumps actions/checkout from 3 to 4.

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v4.0.0

v3.6.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3.5.3...v3.6.0

v3.5.3

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v3.5.3

v3.5.2

What's Changed

Full Changelog: actions/checkout@v3.5.1...v3.5.2

v3.5.1

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.0.0

v3.6.0

v3.5.3

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

v3.1.0

v3.0.2

v3.0.1

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #237 (480b10f) into master (e2faa70) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   94.41%   94.42%   +0.01%     
==========================================
  Files          30       30              
  Lines        1612     1615       +3     
==========================================
+ Hits         1522     1525       +3     
  Misses         90       90              
Flag Coverage Δ
unittests 94.42% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mytoyota/client.py 97.91% <100.00%> (ø)
tests/test_myt.py 100.00% <100.00%> (ø)
tests/test_sensors.py 100.00% <100.00%> (ø)
tests/test_vehicle.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@joro75
Copy link
Collaborator

joro75 commented Nov 11, 2023

I probably know what is going wrong with the checks, that prevent the commit to merge. Will try to fix it...

@joro75 joro75 self-assigned this Nov 11, 2023
@joro75
Copy link
Collaborator

joro75 commented Nov 11, 2023

The installation of PyYAML 6.0 is causing problems on Python 3.12. Could it be that PyYAML 6.0 is not compatible with Python 3.12?? I will investigate it.

It indeed seems to be a problem of PyYAML 6.0 in combination with Python 3.12. The problem is fixed in PyYAML 6.0.1. Also see: yaml/pyyaml#736

@joro75
Copy link
Collaborator

joro75 commented Nov 11, 2023

The github actions and checks are working again, and the commit can now be performed with all checks passing.

!! However: it was needed to update several dependencies to a newer version to support the Python 3.12 version. This also causes problems with supporting older versions as those dependencies do not support Python 3.7 anymore. The minimum requirement on Python now has been updated to >= Python 3.8.1

@DurgNomis-drol Can you review and approve?

DurgNomis-drol
DurgNomis-drol previously approved these changes Nov 13, 2023
pyproject.toml Show resolved Hide resolved
@DurgNomis-drol
Copy link
Owner

Please run poetry update to update the lock file before we can resolve the merge conflicts 🚀

@joro75 joro75 merged commit 1288d94 into master Nov 13, 2023
22 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-4 branch November 13, 2023 17:37
@DurgNomis-drol
Copy link
Owner

I will release a new version of this, so we can test it in the HA integration 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants