Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proof of concept] Assign noble positions #148

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cvuchener
Copy link
Contributor

@cvuchener cvuchener commented Jan 10, 2019

A very crude interface for assigning noble position: right-click on a dwarf, then "Assign noble position..." and choose. Click "Commit changes" to make the actual change in-game.

It injects a call to a DF function that should hopefully make all the necessary changes to cleanly assign a dwarf to a noble position.

Limitations and known issues:

  • linux only (memory layouts included for 0.44.12 linux64/linux32) linux 32/64 bits and windows 64 bits only (only memory layouts for 0.44.12 included).
  • any position can be assigned even if it shouldn't be available
  • missing new militia captain assignments
  • require refresh after commit to show the new nobles
  • do not commit noble position while the nobles viewscreen is open in DF (it will try to overwrite changes when closing)

I am still not sure if this is the right method, be careful, it may corrupt your saves.

@cvuchener cvuchener added the WIP label Jan 10, 2019
@cvuchener
Copy link
Contributor Author

added port for windows 64 bits

Wow64 is not working because the debug thread is 64 bits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant