Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory layouts for 0.47.01 #185

Merged
merged 3 commits into from Feb 12, 2020

Conversation

cvuchener
Copy link
Contributor

No description provided.

@woj1993
Copy link

woj1993 commented Jan 30, 2020

I have problem that every dwarf is seen as visitor so I can't commit any changes is this normal? Animals works correctly.

Edit: Windows 10 64 bits

@clinodev
Copy link

clinodev commented Jan 30, 2020

Interesting, I just assumed these were preliminary when it consistently failed to "Not Responding" at "Loading Units" of 31-37%, for the same fort on the same tick, mind you. Win64

https://imgur.com/sGeyZJ3

@cvuchener
Copy link
Contributor Author

I have problem that every dwarf is seen as visitor so I can't commit any changes is this normal?

I saw that too (on linux) and a lot of other errors. It is still early and df-structures has not been updated much yet. I only merged Quietust patches (DFHack/df-structures#340).

@cvuchener
Copy link
Contributor Author

It's getting better. I've only seen material names errors, but I did not test much.

@cvuchener
Copy link
Contributor Author

The last update should item materials (on all platform except win64 where it was already working) and historical figures.

@woj1993
Copy link

woj1993 commented Feb 3, 2020

I can confirm that win64 is pretty stable. I was playing yesterday for 8 hours and hasn't found any errors.

@BigSnicker
Copy link

BigSnicker commented Feb 3, 2020

So I took a shot at building this branch, despite being pretty unfamiliar with cmake, and failed pretty miserably (i.e. the Ubuntu version compiled successfully but couldn't detect the active DF process and the Win64 version repeatedly gave me "could not find any instance of Visual Studio").

So any idea when this will be released as compiled releases that support 47.01?

@woj1993
Copy link

woj1993 commented Feb 3, 2020

@BigSnicker What is your system?
Download version for your system from http://www.bay12forums.com/smf/index.php?topic=168411.0 or https://github.com/Dwarf-Therapist/Dwarf-Therapist/releases/tag/v41.1.2.
Next download files from this branch that matches your system and place it in DwarfTherapist/data/memory_layouts/[yoursystem]/[here] .
It should detect new memory layout and connect.

@BigSnicker
Copy link

Excellent, I'll give it a shot. Primary system is boring ol' Windows 10/64bit x86 and backup is the same architecture on Ubuntu.

Looking forward to it! Thanks for all your work, guys.

@bwach
Copy link

bwach commented Feb 3, 2020

@cvuchener amazing work, thank You! May forgotten beasts bring much "fun" to your forts whenever you expect it the least!

As for feedback, I had an issue

  • filter was set to "migration wave"
  • migrants were identified as "non citizens" until I re-read

Is it due to memory mapping or that's how it should be now?

@cvuchener
Copy link
Contributor Author

So any idea when this will be released as compiled releases that support 47.01?

There was no code changed since last release, you can simply add the new memory layouts to your current installation. There will be a new release when the work on the memory layout is finished.

@cvuchener
Copy link
Contributor Author

As for feedback, I had an issue

  • filter was set to "migration wave"
  • migrants were identified as "non citizens" until I re-read

Is it due to memory mapping or that's how it should be now?

That's not normal. I don't know how this could happen. I can't even find where this string comes from (was it really "citizen" or another word?). But I don't think this is a memory layout issue.

Copy link

@domq domq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

v0.47.02 confirmed working on Mac OS X Catalina. Thank you!!

@cvuchener cvuchener merged commit 84fdca5 into Dwarf-Therapist:master Feb 12, 2020
@cvuchener cvuchener deleted the 0.47.01-memory-layouts branch February 12, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants