JSON.Net - Initial support #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compile time option (USE_JSON_NET) to use JSON.Net instead of JsonFx.
|
Until there are failing unit tests I am unsure if and when to merge this. I got some ideas for API breaking changes that will be the next major versions, but I have a lot on my plate and no ETA on this. Failing tests means that shouldn't go into master without changing the API or reworking the tests. |
|
closed for now, please reopen when this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compile time option (USE_JSON_NET) to use JSON.Net instead of
JsonFx. 25 of 31 unit tests pass (primarily, the tests that deal with nested objects/arrays fail because JSON.Net won't return these as ExpandoObjects).