-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfancify #12
Unfancify #12
Conversation
… in both Sandbox and DynamoRevit
awesome stuff! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this with my limited experience with extensions, it looks awesome to me. I am looking forward to this lab and am thrilled to be helping out. Not sure who needs to merge this, but I like it! 👍
CBW227909 - View Extensions for C# Beginners/sample_graphs/Core_AttractorPoint.dyn
Show resolved
Hide resolved
@@ -0,0 +1,1300 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnpierson Could you try resaving it in your English language Sandbox and see if the descriptions are updated in English? If so, could you commit the changed version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even after resaving, it staus. But just for the string node. That is a little odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnpierson Let's try to reproduce that in Vegas. Smells like a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does the actual json
of the DYN file say ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bug - serializing the description in localized language is fine, but it should not deserialize it from here anyway - I don't think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnpierson can you verify if this is also an issue for other base types like double or slider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjkkirschner For the sliders, it is working as expected. Need to find a graph with a double.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnpierson can you also clarify - do new nodes have the correct english description?
@@ -0,0 +1,4 @@ | |||
<ViewExtensionDefinition> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving the name BTW. We need to make a logo for it I think. :) One of the really fun parts of being a Dynamo developer is branding this stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnpierson Got an idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a sheen of paper being rolled back - where 'fancify' is fancy and the 'un' is not... like steel, or rusty, or jagged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quite like the one with the bow-tie :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @johnpierson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Purpose
This is the maximum of what we'll do during our session.
Most likely we will not get through all the functionality.
Before execution:
After execution:
FYI
@radumg
@teocomi
@wynged
@LongNguyenP