-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking for a way to handle a user clicking (x) to close a sidebar extension #11060
Comments
@johnpierson I know this is going to come up at some time :) I still need to confirm with @Amoursol that we would like to encourage 3rd party extensions to be able to add Dynamo menu items. If that is the case, we can expose this event to unblock you. |
Hi @johnpierson . Just chiming in to say that thesaurus looks very intriguing. Is that some sort ML driven tool to suggest nodes related to the ones you add? |
@mmisol - @QilongTang worked on this! Feel free to reach out internally 😄 |
Hi @johnpierson! Are you looking to simply have a tick removed from a menu item when that same extension is closed in the sidebar panel? If so, I'm 💯 on board with opening that up @QilongTang. |
That’s the goal! 🙂
…On Thu, Aug 27, 2020 at 8:28 AM Sol Amour ***@***.***> wrote:
Hi @johnpierson <https://github.com/johnpierson>!
Are you looking to simply have a tick removed from a menu item when that
same extension is closed in the sidebar panel? If so, I'm 💯 on board
with opening that up @QilongTang <https://github.com/QilongTang>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11060 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYD5VFLKITUMPVM3BDLK43SCZURHANCNFSM4QMIVY2Q>
.
|
@Amoursol This should be small effort given just making the event public. Do you want to make it available in Dynamo 2.8 given it will probably gain popularity? |
@QilongTang if you have time to squeeze this in, then yes please. |
I actually think I can work around this using Here is how I am handling it in SimpleSearch right now,
|
Glad to hear it @johnpierson ! |
Dynamo version
Dynamo 2.6.1
Operating system
Windows 10
What did you do?
Trying to implement a handler that unchecks a menu item when a sidebar view extension is closed. Kind of like this,
Dynamo/src/WorkspaceDependencyViewExtension/WorkspaceDependencyView.xaml.cs
Line 180 in fd18ceb
What did you expect to see?
The ability to subscribe to its closing event to uncheck it.
What did you see instead?
It is internal. 🤦
Dynamo/src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs
Line 80 in 0a72ece
The text was updated successfully, but these errors were encountered: