Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsConnected on PortModel should be public #8902

Closed
teocomi opened this issue May 31, 2018 · 7 comments
Closed

IsConnected on PortModel should be public #8902

teocomi opened this issue May 31, 2018 · 7 comments
Labels
2.x Issues related to 2.x versions of Dynamo. developer experience more high-level issues that are more specific to individuals actively developing on Dynamo.

Comments

@teocomi
Copy link

teocomi commented May 31, 2018

I think the IsConnected property should be public:

https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCore/Graph/Nodes/PortModel.cs#L290

At least according to this document:

http://developer.dynamobim.org/03-Development-Options/upgrade-nodes-for-dynamo-20.html

Current workaround InPorts[0].Connectors.Any()

Dynamo version

2.0.1.5055

@QilongTang
Copy link
Contributor

Sounds reasonable. FYI: @mjkkirschner @Racel @ramramps

@mjkkirschner
Copy link
Member

yep, seems this should be public.

@QilongTang
Copy link
Contributor

@mjkkirschner If this is only matters to developers, I think we can commit to the 2.0.1 branch and re upload the nugets or we can fix our documentation and include the fix in 2.1

@mjkkirschner
Copy link
Member

I think in most cases additions of new apis should be 2.1 - in which case we should add to master only.

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

but it's all fuzzy anyway ;)

@QilongTang
Copy link
Contributor

@mjkkirschner OK, let's do it in 2.1

@johnpierson johnpierson added Wishlist priority Related to a release. 2.x Issues related to 2.x versions of Dynamo. and removed 2.1 Release API labels Sep 20, 2018
@johnpierson johnpierson added developer experience more high-level issues that are more specific to individuals actively developing on Dynamo. and removed priority Related to a release. labels Nov 28, 2018
@mjkkirschner
Copy link
Member

@QilongTang - you fixed this yes?

@QilongTang
Copy link
Contributor

@mjkkirschner Yes, mentioned in our API changes doc here https://github.com/DynamoDS/Dynamo/wiki/API-Changes#dynamocore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues related to 2.x versions of Dynamo. developer experience more high-level issues that are more specific to individuals actively developing on Dynamo.
Projects
None yet
Development

No branches or pull requests

5 participants