New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsConnected on PortModel should be public #8902
Comments
Sounds reasonable. FYI: @mjkkirschner @Racel @ramramps |
yep, seems this should be public. |
@mjkkirschner If this is only matters to developers, I think we can commit to the 2.0.1 branch and re upload the nugets or we can fix our documentation and include the fix in 2.1 |
I think in most cases additions of new apis should be 2.1 - in which case we should add to master only.
but it's all fuzzy anyway ;) |
@mjkkirschner OK, let's do it in 2.1 |
@QilongTang - you fixed this yes? |
@mjkkirschner Yes, mentioned in our API changes doc here https://github.com/DynamoDS/Dynamo/wiki/API-Changes#dynamocore |
I think the IsConnected property should be public:
https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCore/Graph/Nodes/PortModel.cs#L290
At least according to this document:
http://developer.dynamobim.org/03-Development-Options/upgrade-nodes-for-dynamo-20.html
Current workaround
InPorts[0].Connectors.Any()
Dynamo version
2.0.1.5055
The text was updated successfully, but these errors were encountered: