New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Node failing downstream causes Null's upstream #9073
Comments
@aparajit-pratap @mjkkirschner @Racel This is some funky behaviour :) |
It depends what your two python nodes do - most of our libraries are immutable, but you could do anything in python(including disposing geometry that another node produced). Can you share the .dyn or a smaller sample that reproduces the issue? |
Hi Mike, |
Nope, if you pass in geometry to your python node and call dispose on it - you're disposing it. You must be careful not to dispose objects that are referenced in other places. |
Thanks for clarifying. Would be worth adding these notes to the documentation around disposing in the primer etc |
Seconding @MarkThorley 's suggestion - this sounds like a messaging issue. Assumptions were that downstream graphs couldn't affect upstream nodes. In retrospect very obvious but not so at the time. |
I would say that it should get added to the wiki. This sounds like a rather advanced concept for the primer? The ZeroTouch section already mentions some of the considerations with Disposing as well. |
If this issue is with Dynamo for Revit, please post your issue on the Dynamo for Revit Issues page.
If this issue is not a bug report or improvement request, please check the Dynamo forum, and start a thread there to discuss your issue.
Dynamo version
Dynamo Core 2.0.1.5055
Dynamo Revit 2.0.1.5065
Operating system
Windows 10
What did you do?
I have broken some of my Python code downstream (Causing the node to error out). This resulted in prior Python nodes breaking (Refer to the attached GIF).
What did you expect to see?
All upstream Python code executing correctly. An error message on the failing node to simply point out the error at that point.
What did you see instead?
Downstream Python node failure causes 'null' returns upstream.
The text was updated successfully, but these errors were encountered: