Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization Improvements 05/10/15 #4498

Merged
merged 13 commits into from
May 20, 2015
Merged

Conversation

ikeough
Copy link
Contributor

@ikeough ikeough commented May 17, 2015

Purpose

This PR adds additional improvements to the visualization pipeline using Helix 3D.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • The level of testing this PR includes is appropriate
    • No new tests added.

Reviewers

@pboyer

FYIs

@jnealb

@ikeough ikeough added the WIP label May 17, 2015
@ikeough ikeough self-assigned this May 17, 2015
@ikeough ikeough changed the title Visualization improvements 0510 Visualization Improvements 05/10/15 May 17, 2015
@ikeough ikeough added PTAL Please Take A Look 👀 and removed WIP labels May 20, 2015
@ikeough ikeough assigned pboyer and unassigned ikeough May 20, 2015
@@ -202,6 +202,8 @@ public double LightElevationDegrees
set { lightElevationDegrees = value; }
}

public Dynamo.UI.Commands.DelegateCommand TestSelectionCommand { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some explanation here.

@pboyer
Copy link
Contributor

pboyer commented May 20, 2015

Just a few comments here. Once you've made the changes and the builds pass then LGTM.

ikeough pushed a commit that referenced this pull request May 20, 2015
@ikeough ikeough merged commit 50ee81e into master May 20, 2015
@ikeough ikeough deleted the VisualizationImprovements_0510 branch May 20, 2015 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants