Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate package upload to NuGet Gallery and Artifactory #7511

Merged
merged 2 commits into from Jan 16, 2017

Conversation

ellensi
Copy link
Contributor

@ellensi ellensi commented Jan 16, 2017

Purpose

Change the folder structure and adjust the batch files in order to support separated upload to the NuGet Gallery and to the Artifactory server. Batch file PostNugetPackages.bat requires the NuGet Gallery API key as the only parameter, while PostArtifactoryPackages.bat will try to fetch the Artifactory credentials from the NuGet config file.

Dynamo\tools\NuGet\BuildPackages.bat
Dynamo\tools\NuGet\PostNugetPackages.bat  -->  argument %1: API key for www.nuget.org
Dynamo\tools\NuGet\PostArtifactoryPackages.bat

Dynamo\tools\NuGet\template-nuget\DynamoVisualProgramming.Core.nuspec
Dynamo\tools\NuGet\template-nuget\DynamoVisualProgramming.DynamoCoreNodes.nuspec
Dynamo\tools\NuGet\template-nuget\DynamoVisualProgramming.DynamoServices.nuspec
Dynamo\tools\NuGet\template-nuget\DynamoVisualProgramming.Tests.nuspec
Dynamo\tools\NuGet\template-nuget\DynamoVisualProgramming.WpfUILibrary.nuspec
Dynamo\tools\NuGet\template-nuget\DynamoVisualProgramming.ZeroTouchLibrary.nuspec

Dynamo\tools\NuGet\template-artifactory\DynamoVisualProgramming.DynamoCoreRuntime.nuspec

Reviewers

@sharadkjaiswal @DynamoEngOps

set Artifactory=https://art-bobcat.autodesk.com/artifactory/api/nuget/team-dynamo-nuget

:: Push Runtime package to Artifactory
nuget push *.nupkg -source %Artifactory% -apikey %1
Copy link
Contributor

@DynamoEngOps DynamoEngOps Jan 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:: Use credentials in config file for pushing package to Artifactory
SET ConfigPath=%~dp0..\..\dynamo-nuget.config
nuget push DynamoVisualProgramming.DynamoCoreRuntime.*.nupkg -source %Artifactory% -configfile %ConfigPath%

@DynamoEngOps
Copy link
Contributor

Looks good to me

@sharadkjaiswal
Copy link
Contributor

you might need to merge this to RC1.2.2 branch as well.

@ellensi
Copy link
Contributor Author

ellensi commented Jan 16, 2017

Thanks all for reviewing. All the NuGet changes are pushed to RC1.2.2_master in PR #7514.

@ellensi ellensi merged commit 48879cf into DynamoDS:master Jan 16, 2017
@ellensi ellensi deleted the NuGet branch February 2, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants