use fromexisting constructor for creating family from name via document #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinDayOrg
reviewed
Nov 9, 2017
|
|
||
| RunCurrentModel(); | ||
|
|
||
| //assert number of loaded families in document: |
There was a problem hiding this comment.
This comment says "assert", but there is no assert here. Not a big deal, but somewhat confusing. The same for the other comment below about asserting.
There was a problem hiding this comment.
Can we add a summery of the test somewhere, e.g. sth like This test check to ensure that deleting the family.byName node does not delete the family in Revit host document
ColinDayOrg
reviewed
Nov 9, 2017
| var families2 = fec2.Cast<Autodesk.Revit.DB.Family>(); | ||
| var newcount = families.Count(); | ||
|
|
||
| Assert.AreEqual(oldcount, newcount); |
There was a problem hiding this comment.
The comment about asserting should probably be here for clarity.
|
A couple of comments about the comments in the code (minor, change them if you agree, but I'm ok if it stays as it is), but other than that LGTM. |
This was referenced Nov 9, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
when we create families using the byBame node this implies that the elements already exist in the document and are revit owned - use the from existing constructor to set the
RevitOwnedbool to false.add a test which checks the total number of families before and after removing this node from the graph.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@ColinDayOrg
FYIs
@QilongTang